LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html - Issue 85263002: Improve handling of dictionary conversions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/opera/interfaces/TrackEvent/constructor.html

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/events/constructors/wheel-event-constructor-expected.txt ('k') | LayoutTests/media/track/opera/interfaces/TrackEvent/constructor-expected.txt » ('j') | Source/bindings/v8/Dictionary.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <title>TrackEvent constructor</title>	2 <title>TrackEvent constructor</title>

3 <script src=../../../../../resources/testharness.js></script>	3 <script src=../../../../../resources/testharness.js></script>

4 <script src=../../../../../resources/testharnessreport.js></script>	4 <script src=../../../../../resources/testharnessreport.js></script>

5 <div id=log></div>	5 <div id=log></div>

6 <script>	6 <script>

7 test(function(){	7 test(function(){

8 var ev = new TrackEvent('foo');	8 var ev = new TrackEvent('foo');

9 assert_true(ev instanceof TrackEvent, 'ev instanceof TrackEvent');	9 assert_true(ev instanceof TrackEvent, 'ev instanceof TrackEvent');

10 assert_true(ev instanceof Event, 'ev instanceof Event');	10 assert_true(ev instanceof Event, 'ev instanceof Event');

11 assert_equals(ev.track, null, 'ev.track');	11 assert_equals(ev.track, null, 'ev.track');

12 ev.track = {};	12 ev.track = {};

13 assert_equals(ev.track, null, 'ev.track after assignment');	13 assert_equals(ev.track, null, 'ev.track after assignment');

14 }, document.title+', one arg');	14 }, document.title+', one arg');

15 test(function(){	15 test(function(){

16 var obj = {};	16 var obj = {};

17 var ev = new TrackEvent('foo', {track:obj});	17 try {

	18 var ev = new TrackEvent('foo', {track:obj});

	19 assert_unreached("Expected constructor to throw TypeError");

	20 } catch (e) {

	21 assert_true(e instanceof TypeError);

	22 }

	23 var ev = new TrackEvent('foo', {});

18 assert_true(ev instanceof TrackEvent, 'ev instanceof TrackEvent');	24 assert_true(ev instanceof TrackEvent, 'ev instanceof TrackEvent');

19 assert_true(ev instanceof Event, 'ev instanceof Event');	25 assert_true(ev instanceof Event, 'ev instanceof Event');

20 assert_equals(ev.track, obj, 'ev.track');	26 assert_equals(ev.track, null, 'ev.track');

21 ev.track = {};	27 ev.track = {};

22 assert_equals(ev.track, obj, 'ev.track after assignment');	28 assert_equals(ev.track, null, 'ev.track after assignment');

23 }, document.title+', two args');	29 }, document.title+', two args');

24 </script>	30 </script>

OLD	NEW