Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 852283003: Revert of Update GPU memory buffers to use StrideInBytes internally. (Closed)

Created:
5 years, 11 months ago by ricow1
Modified:
5 years, 11 months ago
Reviewers:
christiank, reveman, jbauman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, auygun, peterp
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update GPU memory buffers to use StrideInBytes internally. (patchset #4 id:60001 of https://codereview.chromium.org/806653006/) Reason for revert: This seems to be causing a lot of redness, e.g. http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%281%29&number=35371 Original issue's description: > Update GPU memory buffers to use StrideInBytes internally. > > Tile texture compression will add support for GPU memory buffer formats > that use less than a byte per pixel. > > This CL prepares GPU buffers for this by using a new function > StrideInBytes instead of relying on bytes per pixel calculations when > calculating the number of bytes needed to store a certain number of pixels. > > BUG=434699 > > Committed: https://crrev.com/53e678c7962e12efe4bca3b58c9efbf755b86798 > Cr-Commit-Position: refs/heads/master@{#311862} TBR=reveman@chromium.org,jbauman@chromium.org,christiank@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434699 Committed: https://crrev.com/6911a56b2521cf651378312f599b9e043fd6c30b Cr-Commit-Position: refs/heads/master@{#311891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -106 lines) Patch
M cc/test/test_gpu_memory_buffer_manager.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.h View 1 chunk +3 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 4 chunks +5 lines, -30 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/gl/gl_image_memory.h View 2 chunks +1 line, -4 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
Created Revert of Update GPU memory buffers to use StrideInBytes internally.
5 years, 11 months ago (2015-01-16 14:19:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852283003/1
5 years, 11 months ago (2015-01-16 14:19:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 14:20:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6911a56b2521cf651378312f599b9e043fd6c30b Cr-Commit-Position: refs/heads/master@{#311891}
5 years, 11 months ago (2015-01-16 14:22:05 UTC) #4
Timur Iskhodzhanov
5 years, 11 months ago (2015-01-16 15:15:12 UTC) #5
Message was sent while issue was closed.
I've meant to revert it but you were first :)
BUG=449524

Powered by Google App Engine
This is Rietveld 408576698