Issue 852113002: Remove RawChannel::Init() and Channel::Init() failure cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 852113002: Remove RawChannel::Init() and Channel::Init() failure cases. (Closed)

Created:
5 years, 11 months ago by viettrungluu

Modified:
5 years, 11 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove RawChannel::Init() and Channel::Init() failure cases. I don't know how they'd ever fail, unless the FD/handle passed in was bad (in which case our code is buggy, and we should CHECK-fail). (As a consequence I don't know how to reasonably test these failure code paths either.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1d7c0102b163850f345a1ad966e99a9188499626

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -153 lines)			Patch
M	mojo/edk/embedder/embedder.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	mojo/edk/system/channel.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/system/channel.cc	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	mojo/edk/system/channel_unittest.cc	View	9 chunks	+2 lines, -87 lines	0 comments	Download
M	mojo/edk/system/message_pipe_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	mojo/edk/system/raw_channel.cc	View	3 chunks	+4 lines, -12 lines	0 comments	Download
M	mojo/edk/system/raw_channel_posix.cc	View	3 chunks	+8 lines, -14 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel_win.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	mojo/edk/system/remote_message_pipe_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 11 months ago (2015-01-15 22:51:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1d7c0102b163850f345a1ad966e99a9188499626 (presubmit successful).

Expand Messages | Collapse Messages