Remove RawChannel::Init() and Channel::Init() failure cases.

mojo/edk/system/raw_channel_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/raw_channel.h"
 
 #include <windows.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 150 matching lines @@
 
   // |RawChannel| private methods:
   IOResult Read(size_t* bytes_read) override;
   IOResult ScheduleRead() override;
   embedder::ScopedPlatformHandleVectorPtr GetReadPlatformHandles(
       size_t num_platform_handles,
       const void* platform_handle_table) override;
   IOResult WriteNoLock(size_t* platform_handles_written,
                        size_t* bytes_written) override;
   IOResult ScheduleWriteNoLock() override;
-  bool OnInit() override;
+  void OnInit() override;
   void OnShutdownNoLock(scoped_ptr<ReadBuffer> read_buffer,
                         scoped_ptr<WriteBuffer> write_buffer) override;
 
   // Passed to |io_handler_| during initialization.
   embedder::ScopedPlatformHandle handle_;
 
   RawChannelIOHandler* io_handler_;
 
   const bool skip_completion_port_on_success_;
 
@@ skipping 332 matching lines @@
         base::Bind(&RawChannelIOHandler::OnIOCompleted,
                    base::Unretained(io_handler_),
                    base::Unretained(io_handler_->write_context_no_lock()),
                    static_cast<DWORD>(bytes_written), ERROR_SUCCESS));
     return IO_PENDING;
   }
 
   return io_result;
 }
 
-bool RawChannelWin::OnInit() {
+void RawChannelWin::OnInit() {
   DCHECK_EQ(base::MessageLoop::current(), message_loop_for_io());
 
   DCHECK(handle_.is_valid());
-  if (skip_completion_port_on_success_ &&
-      !g_vista_or_higher_functions.Get().SetFileCompletionNotificationModes(
-          handle_.get().handle, FILE_SKIP_COMPLETION_PORT_ON_SUCCESS)) {
-    return false;
+  if (skip_completion_port_on_success_) {
+    // I don't know how this can fail (unless |handle_| is bad, in which case
+    // it's a bug in our code).
+    CHECK(g_vista_or_higher_functions.Get().SetFileCompletionNotificationModes(
+        handle_.get().handle, FILE_SKIP_COMPLETION_PORT_ON_SUCCESS));
   }
 
   DCHECK(!io_handler_);
   io_handler_ = new RawChannelIOHandler(this, handle_.Pass());
-
-  return true;
 }
 
 void RawChannelWin::OnShutdownNoLock(scoped_ptr<ReadBuffer> read_buffer,
                                      scoped_ptr<WriteBuffer> write_buffer) {
   DCHECK_EQ(base::MessageLoop::current(), message_loop_for_io());
   DCHECK(io_handler_);
 
   write_lock().AssertAcquired();
 
   if (io_handler_->pending_read() || io_handler_->pending_write_no_lock()) {
@@ skipping 20 matching lines @@
 
 // Static factory method declared in raw_channel.h.
 // static
 scoped_ptr<RawChannel> RawChannel::Create(
     embedder::ScopedPlatformHandle handle) {
   return make_scoped_ptr(new RawChannelWin(handle.Pass()));
 }
 
 }  // namespace system
 }  // namespace mojo