Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 852103002: Revert of Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA (patchset #1 id:20001 of https://codereview.chromium.org/813693006/) Reason for revert: This is breaking arm builds. See for example: https://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4129/steps/cbuildbot/logs/stdio Original issue's description: > Reland: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA. > > This is a reland as the previous CL has an issue with BUILD.gn and failed gn build. > > An AcceleratedVideoDecoder is a video decoder that requires support from an > external accelerator (typically a hardware accelerator) to partially > offload the decode process after parsing stream headers, and performing > reference frame and state management. > > In this design, the hardware-independent decoder implementation interfaces > with a HW-specific Accelerator to offload last stages of the decode process. > > Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264, > V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client > class for V4L2. > > TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode > BUG=chrome-os-partner:33728 > TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org > > Committed: https://crrev.com/3c09b9b26ee6fc8b43c7535070cfa08aba1285cf > Cr-Commit-Position: refs/heads/master@{#311464} TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org,posciak@chromium.org NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:33728 Committed: https://crrev.com/e69d5cb6c3076d61c4f86677987cca579c968af4 Cr-Commit-Position: refs/heads/master@{#311561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -5317 lines) Patch
M content/common/BUILD.gn View 1 chunk +2 lines, -13 lines 0 comments Download
D content/common/gpu/media/accelerated_video_decoder.h View 1 chunk +0 lines, -63 lines 0 comments Download
M content/common/gpu/media/generic_v4l2_video_device.h View 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/gpu/media/h264_decoder.h View 1 chunk +0 lines, -259 lines 0 comments Download
D content/common/gpu/media/h264_decoder.cc View 1 chunk +0 lines, -1275 lines 0 comments Download
M content/common/gpu/media/h264_dpb.h View 6 chunks +17 lines, -41 lines 0 comments Download
M content/common/gpu/media/h264_dpb.cc View 5 chunks +27 lines, -47 lines 0 comments Download
M content/common/gpu/media/tegra_v4l2_video_device.h View 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_image_processor.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_image_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/gpu/media/v4l2_slice_video_decode_accelerator.h View 1 chunk +0 lines, -391 lines 0 comments Download
D content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc View 1 chunk +0 lines, -2432 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.h View 4 chunks +5 lines, -9 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 2 chunks +10 lines, -20 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.h View 6 chunks +11 lines, -11 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.cc View 33 chunks +53 lines, -59 lines 0 comments Download
D content/common/gpu/media/vaapi_h264_dpb.h View 1 chunk +0 lines, -138 lines 0 comments Download
D content/common/gpu/media/vaapi_h264_dpb.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 7 chunks +16 lines, -24 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/gpu/media/vp8_decoder.h View 1 chunk +0 lines, -107 lines 0 comments Download
D content/common/gpu/media/vp8_decoder.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D content/common/gpu/media/vp8_picture.h View 1 chunk +0 lines, -29 lines 0 comments Download
D content/common/gpu/media/vp8_picture.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -13 lines 0 comments Download
M media/filters/h264_parser.h View 2 chunks +1 line, -7 lines 0 comments Download
M media/filters/h264_parser.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M media/filters/vp8_parser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/video/h264_poc.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-14 22:34:17 UTC) #1
Created Revert of Add accelerated video decoder interface, VP8 and H.264
implementations and hook up to V4L2SVDA

Powered by Google App Engine
This is Rietveld 408576698