It is time.

ui/views/controls/button/menu_button.cc

Index: ui/views/controls/button/menu_button.cc
diff --git a/ui/views/controls/button/menu_button.cc b/ui/views/controls/button/menu_button.cc
deleted file mode 100644
index debd227b802b2e43c2bc4a735be6e1d1a002ad2e..0000000000000000000000000000000000000000
--- a/ui/views/controls/button/menu_button.cc
+++ /dev/null
@@ -1,318 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ui/views/controls/button/menu_button.h"
-
-#include "base/strings/utf_string_conversions.h"
-#include "ui/accessibility/ax_view_state.h"
-#include "ui/base/dragdrop/drag_drop_types.h"
-#include "ui/base/l10n/l10n_util.h"
-#include "ui/base/resource/resource_bundle.h"
-#include "ui/events/event.h"
-#include "ui/events/event_constants.h"
-#include "ui/gfx/canvas.h"
-#include "ui/gfx/image/image.h"
-#include "ui/gfx/screen.h"
-#include "ui/gfx/text_constants.h"
-#include "ui/resources/grit/ui_resources.h"
-#include "ui/strings/grit/ui_strings.h"
-#include "ui/views/controls/button/button.h"
-#include "ui/views/controls/button/menu_button_listener.h"
-#include "ui/views/mouse_constants.h"
-#include "ui/views/widget/root_view.h"
-#include "ui/views/widget/widget.h"
-
-using base::TimeTicks;
-using base::TimeDelta;
-
-namespace views {
-
-// Default menu offset.
-static const int kDefaultMenuOffsetX = -2;
-static const int kDefaultMenuOffsetY = -4;
-
-// static
-const char MenuButton::kViewClassName[] = "MenuButton";
-const int MenuButton::kMenuMarkerPaddingLeft = 3;
-const int MenuButton::kMenuMarkerPaddingRight = -1;
-
-////////////////////////////////////////////////////////////////////////////////
-//
-// MenuButton::PressedLock
-//
-////////////////////////////////////////////////////////////////////////////////
-
-MenuButton::PressedLock::PressedLock(MenuButton* menu_button)
-    : menu_button_(menu_button->weak_factory_.GetWeakPtr()) {
-  menu_button_->IncrementPressedLocked();
-}
-
-MenuButton::PressedLock::~PressedLock() {
-  if (menu_button_.get())
-    menu_button_->DecrementPressedLocked();
-}
-
-////////////////////////////////////////////////////////////////////////////////
-//
-// MenuButton - constructors, destructors, initialization
-//
-////////////////////////////////////////////////////////////////////////////////
-
-MenuButton::MenuButton(ButtonListener* listener,
-                       const base::string16& text,
-                       MenuButtonListener* menu_button_listener,
-                       bool show_menu_marker)
-    : LabelButton(listener, text),
-      menu_offset_(kDefaultMenuOffsetX, kDefaultMenuOffsetY),
-      listener_(menu_button_listener),
-      show_menu_marker_(show_menu_marker),
-      menu_marker_(ui::ResourceBundle::GetSharedInstance().GetImageNamed(
-          IDR_MENU_DROPARROW).ToImageSkia()),
-      destroyed_flag_(NULL),
-      pressed_lock_count_(0),
-      weak_factory_(this) {
-  SetHorizontalAlignment(gfx::ALIGN_LEFT);
-}
-
-MenuButton::~MenuButton() {
-  if (destroyed_flag_)
-    *destroyed_flag_ = true;
-}
-
-////////////////////////////////////////////////////////////////////////////////
-//
-// MenuButton - Public APIs
-//
-////////////////////////////////////////////////////////////////////////////////
-
-bool MenuButton::Activate() {
-  SetState(STATE_PRESSED);
-  if (listener_) {
-    gfx::Rect lb = GetLocalBounds();
-
-    // The position of the menu depends on whether or not the locale is
-    // right-to-left.
-    gfx::Point menu_position(lb.right(), lb.bottom());
-    if (base::i18n::IsRTL())
-      menu_position.set_x(lb.x());
-
-    View::ConvertPointToScreen(this, &menu_position);
-    if (base::i18n::IsRTL())
-      menu_position.Offset(-menu_offset_.x(), menu_offset_.y());
-    else
-      menu_position.Offset(menu_offset_.x(), menu_offset_.y());
-
-    int max_x_coordinate = GetMaximumScreenXCoordinate();
-    if (max_x_coordinate && max_x_coordinate <= menu_position.x())
-      menu_position.set_x(max_x_coordinate - 1);
-
-    // We're about to show the menu from a mouse press. By showing from the
-    // mouse press event we block RootView in mouse dispatching. This also
-    // appears to cause RootView to get a mouse pressed BEFORE the mouse
-    // release is seen, which means RootView sends us another mouse press no
-    // matter where the user pressed. To force RootView to recalculate the
-    // mouse target during the mouse press we explicitly set the mouse handler
-    // to NULL.
-    static_cast<internal::RootView*>(GetWidget()->GetRootView())->
-        SetMouseHandler(NULL);
-
-    bool destroyed = false;
-    destroyed_flag_ = &destroyed;
-
-    // We don't set our state here. It's handled in the MenuController code or
-    // by our click listener.
-
-    listener_->OnMenuButtonClicked(this, menu_position);
-
-    if (destroyed) {
-      // The menu was deleted while showing. Don't attempt any processing.
-      return false;
-    }
-
-    destroyed_flag_ = NULL;
-
-    menu_closed_time_ = TimeTicks::Now();
-
-    // We must return false here so that the RootView does not get stuck
-    // sending all mouse pressed events to us instead of the appropriate
-    // target.
-    return false;
-  }
-  return true;
-}
-
-void MenuButton::OnPaint(gfx::Canvas* canvas) {
-  LabelButton::OnPaint(canvas);
-
-  if (show_menu_marker_)
-    PaintMenuMarker(canvas);
-}
-
-////////////////////////////////////////////////////////////////////////////////
-//
-// MenuButton - Events
-//
-////////////////////////////////////////////////////////////////////////////////
-
-gfx::Size MenuButton::GetPreferredSize() const {
-  gfx::Size prefsize = LabelButton::GetPreferredSize();
-  if (show_menu_marker_) {
-    prefsize.Enlarge(menu_marker_->width() + kMenuMarkerPaddingLeft +
-                         kMenuMarkerPaddingRight,
-                     0);
-  }
-  return prefsize;
-}
-
-const char* MenuButton::GetClassName() const {
-  return kViewClassName;
-}
-
-bool MenuButton::OnMousePressed(const ui::MouseEvent& event) {
-  RequestFocus();
-  if (state() != STATE_DISABLED) {
-    // If we're draggable (GetDragOperations returns a non-zero value), then
-    // don't pop on press, instead wait for release.
-    if (event.IsOnlyLeftMouseButton() &&
-        HitTestPoint(event.location()) &&
-        GetDragOperations(event.location()) == ui::DragDropTypes::DRAG_NONE) {
-      TimeDelta delta = TimeTicks::Now() - menu_closed_time_;
-      if (delta.InMilliseconds() > kMinimumMsBetweenButtonClicks)
-        return Activate();
-    }
-  }
-  return true;
-}
-
-void MenuButton::OnMouseReleased(const ui::MouseEvent& event) {
-  // Explicitly test for left mouse button to show the menu. If we tested for
-  // !IsTriggerableEvent it could lead to a situation where we end up showing
-  // the menu and context menu (this would happen if the right button is not
-  // triggerable and there's a context menu).
-  if (GetDragOperations(event.location()) != ui::DragDropTypes::DRAG_NONE &&
-      state() != STATE_DISABLED && !InDrag() && event.IsOnlyLeftMouseButton() &&
-      HitTestPoint(event.location())) {
-    Activate();
-  } else {
-    LabelButton::OnMouseReleased(event);
-  }
-}
-
-void MenuButton::OnMouseEntered(const ui::MouseEvent& event) {
-  if (pressed_lock_count_ == 0)  // Ignore mouse movement if state is locked.
-    CustomButton::OnMouseEntered(event);
-}
-
-void MenuButton::OnMouseExited(const ui::MouseEvent& event) {
-  if (pressed_lock_count_ == 0)  // Ignore mouse movement if state is locked.
-    CustomButton::OnMouseExited(event);
-}
-
-void MenuButton::OnMouseMoved(const ui::MouseEvent& event) {
-  if (pressed_lock_count_ == 0)  // Ignore mouse movement if state is locked.
-    CustomButton::OnMouseMoved(event);
-}
-
-void MenuButton::OnGestureEvent(ui::GestureEvent* event) {
-  if (state() != STATE_DISABLED && event->type() == ui::ET_GESTURE_TAP &&
-      !Activate()) {
-    // When |Activate()| returns |false|, it means that a menu is shown and
-    // has handled the gesture event. So, there is no need to further process
-    // the gesture event here.
-    return;
-  }
-  LabelButton::OnGestureEvent(event);
-}
-
-bool MenuButton::OnKeyPressed(const ui::KeyEvent& event) {
-  switch (event.key_code()) {
-    case ui::VKEY_SPACE:
-      // Alt-space on windows should show the window menu.
-      if (event.IsAltDown())
-        break;
-    case ui::VKEY_RETURN:
-    case ui::VKEY_UP:
-    case ui::VKEY_DOWN: {
-      // WARNING: we may have been deleted by the time Activate returns.
-      Activate();
-      // This is to prevent the keyboard event from being dispatched twice.  If
-      // the keyboard event is not handled, we pass it to the default handler
-      // which dispatches the event back to us causing the menu to get displayed
-      // again. Return true to prevent this.
-      return true;
-    }
-    default:
-      break;
-  }
-  return false;
-}
-
-bool MenuButton::OnKeyReleased(const ui::KeyEvent& event) {
-  // Override CustomButton's implementation, which presses the button when
-  // you press space and clicks it when you release space.  For a MenuButton
-  // we always activate the menu on key press.
-  return false;
-}
-
-void MenuButton::GetAccessibleState(ui::AXViewState* state) {
-  CustomButton::GetAccessibleState(state);
-  state->role = ui::AX_ROLE_POP_UP_BUTTON;
-  state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS);
-  state->AddStateFlag(ui::AX_STATE_HASPOPUP);
-}
-
-void MenuButton::PaintMenuMarker(gfx::Canvas* canvas) {
-  gfx::Insets insets = GetInsets();
-
-  // Using the Views mirroring infrastructure incorrectly flips icon content.
-  // Instead, manually mirror the position of the down arrow.
-  gfx::Rect arrow_bounds(width() - insets.right() -
-                         menu_marker_->width() - kMenuMarkerPaddingRight,
-                         height() / 2 - menu_marker_->height() / 2,
-                         menu_marker_->width(),
-                         menu_marker_->height());
-  arrow_bounds.set_x(GetMirroredXForRect(arrow_bounds));
-  canvas->DrawImageInt(*menu_marker_, arrow_bounds.x(), arrow_bounds.y());
-}
-
-gfx::Rect MenuButton::GetChildAreaBounds() {
-  gfx::Size s = size();
-
-  if (show_menu_marker_) {
-    s.set_width(s.width() - menu_marker_->width() - kMenuMarkerPaddingLeft -
-                kMenuMarkerPaddingRight);
-  }
-
-  return gfx::Rect(s);
-}
-
-void MenuButton::IncrementPressedLocked() {
-  ++pressed_lock_count_;
-  SetState(STATE_PRESSED);
-}
-
-void MenuButton::DecrementPressedLocked() {
-  --pressed_lock_count_;
-  DCHECK_GE(pressed_lock_count_, 0);
-
-  // If this was the last lock, manually reset state to "normal". We set
-  // "normal" and not "hot" because the likelihood is that the mouse is now
-  // somewhere else (user clicked elsewhere on screen to close the menu or
-  // selected an item) and we will inevitably refresh the hot state in the event
-  // the mouse _is_ over the view.
-  if (pressed_lock_count_ == 0)
-    SetState(STATE_NORMAL);
-}
-
-int MenuButton::GetMaximumScreenXCoordinate() {
-  if (!GetWidget()) {
-    NOTREACHED();
-    return 0;
-  }
-
-  gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
-  return monitor_bounds.right() - 1;
-}
-
-}  // namespace views