Issue 851493004: smoke: remove unused variables and imports, added an explicit null return

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 851493004: smoke: remove unused variables and imports, added an explicit null return (Closed)

Created:
5 years, 11 months ago by kevmoo

Modified:
5 years, 11 months ago

Reviewers:
jakemac

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/smoke@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -5 lines)			Patch
M	lib/mirrors.dart	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	lib/static.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/codegen/end_to_end_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

kevmoo

5 years, 11 months ago (2015-01-27 17:22:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
fa81c3affadd1a8c105a0ac61b0fa7773532554b (presubmit successful).