Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: lib/mirrors.dart

Issue 851493004: smoke: remove unused variables and imports, added an explicit null return (Closed) Base URL: https://github.com/dart-lang/smoke@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/static.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/mirrors.dart
diff --git a/lib/mirrors.dart b/lib/mirrors.dart
index 29742afd4bb69a9a984f362b718050d4c5082a4e..de5feafe42f99215a4b88ee08554d4a898bcf58d 100644
--- a/lib/mirrors.dart
+++ b/lib/mirrors.dart
@@ -152,7 +152,6 @@ class ReflectiveTypeInspectorService implements TypeInspectorService {
if (member is! VariableMirror && member is! MethodMirror) continue;
if (member.isStatic || member.isPrivate) continue;
var name = member.simpleName;
- bool isMethod = false;
if (member is VariableMirror) {
if (!options.includeFields) continue;
if (options.excludeFinal && member.isFinal) continue;
@@ -169,7 +168,6 @@ class ReflectiveTypeInspectorService implements TypeInspectorService {
if (member is MethodMirror && member.isRegularMethod) {
if (!options.includeMethods) continue;
- isMethod = true;
}
if (options.matches != null && !options.matches(name)) continue;
@@ -234,6 +232,7 @@ MethodMirror _findMethod(ClassMirror type, Symbol name) {
if (member is MethodMirror) return member;
type = type.superclass;
} while (type != null);
+ return null;
}
// When recursively looking for symbols up the type-hierarchy it's generally a
« no previous file with comments | « no previous file | lib/static.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698