smoke: remove unused variables and imports, added an explicit null return

lib/mirrors.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Implementation of the smoke services using mirrors.
 library smoke.mirrors;
 
 import 'dart:mirrors';
 import 'package:smoke/smoke.dart';
 import 'package:logging/logging.dart';
@@ skipping 134 matching lines @@
     final visitParent = options.includeInherited && cls.superclass != null && 
         // TODO(sigmund): use _toType(cls.superclass) != options.includeUpTo
         // when dartbug.com/16925 gets fixed (_toType fails in dart2js if
         // applied to classes with type-arguments).
         cls.superclass != reflectClass(options.includeUpTo);
     var result = visitParent ? _query(cls.superclass, options) : [];
     for (var member in cls.declarations.values) {
       if (member is! VariableMirror && member is! MethodMirror) continue;
       if (member.isStatic || member.isPrivate) continue;
       var name = member.simpleName;
-      bool isMethod = false;
       if (member is VariableMirror) {
         if (!options.includeFields) continue;
         if (options.excludeFinal && member.isFinal) continue;
       }
 
       // TODO(sigmund): what if we have a setter but no getter?
       if (member is MethodMirror && member.isSetter) continue;
       if (member is MethodMirror && member.isConstructor) continue;
 
       if (member is MethodMirror && member.isGetter) {
         if (!options.includeProperties) continue;
         if (options.excludeFinal && !_hasSetter(cls, member)) continue;
       }
 
       if (member is MethodMirror && member.isRegularMethod) {
         if (!options.includeMethods) continue;
-        isMethod = true;
       }
 
       if (options.matches != null && !options.matches(name)) continue;
 
       var annotations =
           member.metadata.map((m) => m.reflectee).toList();
       if (options.withAnnotations != null &&
           !matchesAnnotation(annotations, options.withAnnotations)) {
         continue;
       }
@@ skipping 44 matching lines @@
     return _objectType;
   }
 }
 
 MethodMirror _findMethod(ClassMirror type, Symbol name) {
   do {
     var member = type.declarations[name];
     if (member is MethodMirror) return member;
     type = type.superclass;
   } while (type != null);
+  return null;
 }
 
 // When recursively looking for symbols up the type-hierarchy it's generally a
 // good idea to stop at Object, since we know it doesn't have what we want.
 // TODO(jmesserly): This is also a workaround for what appears to be a V8
 // bug introduced between Chrome 31 and 32. After 32
 // JsClassMirror.declarations on Object calls
 // JsClassMirror.typeVariables, which tries to get the _jsConstructor's
 // .prototype["<>"]. This ends up getting the "" property instead, maybe
 // because "<>" doesn't exist, and gets ";" which then blows up because
@@ skipping 64 matching lines @@
   String toString() => (new StringBuffer()
       ..write('(mirror-based-declaration ')
       ..write(name)
       ..write(isField ? ' (field) '
           : (isProperty ? ' (property) ' : ' (method) '))
       ..write(isFinal ? 'final ' : '')
       ..write(isStatic ? 'static ' : '')
       ..write(annotations)
       ..write(')')).toString();
 }