Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 850653002: [turbofan] Improve code generation for unordered comparisons. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve code generation for unordered comparisons. TEST=cctest,unittests Committed: https://crrev.com/c24220c0c14b60e6c6d7383b7d9c287086050afb Cr-Commit-Position: refs/heads/master@{#26034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -397 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 3 chunks +38 lines, -132 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +38 lines, -132 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/instruction-codes.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 12 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-13 08:03:14 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-13 08:11:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/850653002/1
5 years, 11 months ago (2015-01-13 08:13:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 08:41:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 08:42:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24220c0c14b60e6c6d7383b7d9c287086050afb
Cr-Commit-Position: refs/heads/master@{#26034}

Powered by Google App Engine
This is Rietveld 408576698