test/cctest/compiler/test-branch-combine.cc - Issue 850653002: [turbofan] Improve code generation for unordered comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-branch-combine.cc

Issue 850653002: [turbofan] Improve code generation for unordered comparisons. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/compiler/x64/instruction-selector-x64.cc ('k') | test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/compiler/test-branch-combine.cc

diff --git a/test/cctest/compiler/test-branch-combine.cc b/test/cctest/compiler/test-branch-combine.cc

index cd3472d6bb1448f6ba1d952b294f90eeb621035c..618404be5d36df3b1399071677db318e66d3f4db 100644

--- a/test/cctest/compiler/test-branch-combine.cc

+++ b/test/cctest/compiler/test-branch-combine.cc

@@ -444,10 +444,10 @@ TEST(BranchCombineFloat64Compares) {

m.Bind(&blockb);

m.Return(m.Int32Constant(ne_constant));

- for (size_t i = 0; i < arraysize(inputs); i++) {

- for (size_t j = 0; j < arraysize(inputs); j += 2) {

+ for (size_t i = 0; i < arraysize(inputs); ++i) {

+ for (size_t j = 0; j < arraysize(inputs); ++j) {

input_a = inputs[i];

- input_b = inputs[i];

+ input_b = inputs[j];

int32_t expected =

invert ? (cmp.Float64Compare(input_a, input_b) ? ne_constant

: eq_constant)