Issue 848403003: Add missing if (FLAG_verify_heap) checks around heap verification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 848403003: Add missing if (FLAG_verify_heap) checks around heap verification (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Add missing if (FLAG_verify_heap) checks around heap verification BUG=chromium:449943 R=svenpanne@chromium.org LOG=n Committed: https://crrev.com/502407335de60eec82a49529a8339003c033bb37 Cr-Commit-Position: refs/heads/master@{#26127}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -6 lines)			Patch
M	src/api.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/execution.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

Sven Panne

LGTM. But note that this doesn't really catch all things, there is more stuff like ...

5 years, 11 months ago (2015-01-19 09:12:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848403003/1

5 years, 11 months ago (2015-01-19 09:45:35 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-19 10:12:55 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/502407335de60eec82a49529a8339003c033bb37
Cr-Commit-Position: refs/heads/master@{#26127}