Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: src/heap-snapshot-generator.cc

Issue 848403003: Add missing if (FLAG_verify_heap) checks around heap verification (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/execution.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index dec42a8b5fdd1812d488ade889d6f068db530f9f..ec1f645cadb1048bd1f62d615feddb88534b755a 100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -2551,13 +2551,17 @@ bool HeapSnapshotGenerator::GenerateSnapshot() {
#ifdef VERIFY_HEAP
Heap* debug_heap = heap_;
- debug_heap->Verify();
+ if (FLAG_verify_heap) {
+ debug_heap->Verify();
+ }
#endif
SetProgressTotal(2); // 2 passes.
#ifdef VERIFY_HEAP
- debug_heap->Verify();
+ if (FLAG_verify_heap) {
+ debug_heap->Verify();
+ }
#endif
snapshot_->AddSyntheticRootEntries();
« no previous file with comments | « src/execution.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698