Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/execution.cc

Issue 848403003: Add missing if (FLAG_verify_heap) checks around heap verification (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/execution.h" 5 #include "src/execution.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 byte* function_entry = function->code()->entry(); 102 byte* function_entry = function->code()->entry();
103 JSFunction* func = *function; 103 JSFunction* func = *function;
104 Object* recv = *receiver; 104 Object* recv = *receiver;
105 Object*** argv = reinterpret_cast<Object***>(args); 105 Object*** argv = reinterpret_cast<Object***>(args);
106 if (FLAG_profile_deserialization) PrintDeserializedCodeInfo(function); 106 if (FLAG_profile_deserialization) PrintDeserializedCodeInfo(function);
107 value = 107 value =
108 CALL_GENERATED_CODE(stub_entry, function_entry, func, recv, argc, argv); 108 CALL_GENERATED_CODE(stub_entry, function_entry, func, recv, argc, argv);
109 } 109 }
110 110
111 #ifdef VERIFY_HEAP 111 #ifdef VERIFY_HEAP
112 value->ObjectVerify(); 112 if (FLAG_verify_heap) {
113 value->ObjectVerify();
114 }
113 #endif 115 #endif
114 116
115 // Update the pending exception flag and return the value. 117 // Update the pending exception flag and return the value.
116 bool has_exception = value->IsException(); 118 bool has_exception = value->IsException();
117 DCHECK(has_exception == isolate->has_pending_exception()); 119 DCHECK(has_exception == isolate->has_pending_exception());
118 if (has_exception) { 120 if (has_exception) {
119 isolate->ReportPendingMessages(); 121 isolate->ReportPendingMessages();
120 // Reset stepping state when script exits with uncaught exception. 122 // Reset stepping state when script exits with uncaught exception.
121 if (isolate->debug()->is_active()) { 123 if (isolate->debug()->is_active()) {
122 isolate->debug()->ClearStepping(); 124 isolate->debug()->ClearStepping();
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 } 725 }
724 726
725 isolate_->counters()->stack_interrupts()->Increment(); 727 isolate_->counters()->stack_interrupts()->Increment();
726 isolate_->counters()->runtime_profiler_ticks()->Increment(); 728 isolate_->counters()->runtime_profiler_ticks()->Increment();
727 isolate_->runtime_profiler()->OptimizeNow(); 729 isolate_->runtime_profiler()->OptimizeNow();
728 730
729 return isolate_->heap()->undefined_value(); 731 return isolate_->heap()->undefined_value();
730 } 732 }
731 733
732 } } // namespace v8::internal 734 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698