Issue 847813003: Avoid unnecessary float<->LayoutUnit conversions in RenderVTTCue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 847813003: Avoid unnecessary float<->LayoutUnit conversions in RenderVTTCue (Closed)

Created:
5 years, 11 months ago by fs

Modified:
5 years, 11 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Avoid unnecessary float<->LayoutUnit conversions in RenderVTTCue RenderVTTCue::m_fallbackPosition is only used to store the initially computed position of the cue - it does not need to be a FloatPoint. Change the type to LayoutPoint and rename to m_defaultPosition, since that better reflects the naming in spec text. Also cleanup the includes a bit while here. BUG=350474 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188273

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	Source/core/rendering/RenderVTTCue.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	Source/core/rendering/RenderVTTCue.cpp	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847813003/1

5 years, 11 months ago (2015-01-13 08:27:39 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-13 08:31:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188273

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages