Avoid unnecessary float<->LayoutUnit conversions in RenderVTTCue

Source/core/rendering/RenderVTTCue.cpp

 /*
  * Copyright (C) 2012 Victor Carbune (victor@rosedu.org)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
  * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/rendering/RenderVTTCue.h"
 
 #include "core/html/track/vtt/VTTCue.h"
-#include "core/rendering/RenderView.h"
+#include "core/rendering/LayoutState.h"
+#include "core/rendering/RenderInline.h"
 
 namespace blink {
 
 RenderVTTCue::RenderVTTCue(VTTCueBox* element)
     : RenderBlockFlow(element)
     , m_cue(element->getCue())
 {
 }
 
 void RenderVTTCue::trace(Visitor* visitor)
@@ skipping 81 matching lines @@
     if (m_cue->getWritingDirection() == VTTCue::Horizontal) {
         // Horizontal: ... down by the distance given by position
         setY(location().y() + position);
     } else {
         // Vertical: ... right by the distance given by position
         setX(location().x() + position);
     }
 
     // 9. Default: Remember the position of all the boxes in boxes as their
     // default position.
-    // FIXME: Why the direct conversion between float and LayoutUnit? crbug.com/350474
-    m_fallbackPosition = FloatPoint(location());
+    m_defaultPosition = location();
 
     // 10. Let switched be false.
     switched = false;
 }
 
 bool RenderVTTCue::isOutside() const
 {
     return !containingBlock()->absoluteBoundingBoxRect().contains(absoluteContentBox());
 }
 
@@ skipping 49 matching lines @@
     // given by step. (If step is negative, then this will actually
     // result in a leftwards movement of the boxes in absolute terms.)
     else
         setX(location().x() + step);
 }
 
 bool RenderVTTCue::switchDirection(bool& switched, LayoutUnit& step)
 {
     // 15. Switch direction: Move all the boxes in boxes back to their
     // default position as determined in the step above labeled default.
-    setX(m_fallbackPosition.x());
-    setY(m_fallbackPosition.y());
+    setLocation(m_defaultPosition);
 
     // 16. If switched is true, jump to the step labeled done
     // positioning below.
     if (switched)
         return false;
 
     // 17. Negate step.
     step = -step;
 
     // 18. Set switched to true.
@@ skipping 51 matching lines @@
     }
 }
 
 void RenderVTTCue::repositionCueSnapToLinesNotSet()
 {
     // FIXME: Implement overlapping detection when snap-to-lines is not set. http://wkb.ug/84296
 }
 
 } // namespace blink