Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: Source/core/rendering/RenderVTTCue.h

Issue 847813003: Avoid unnecessary float<->LayoutUnit conversions in RenderVTTCue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderVTTCue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org) 2 * Copyright (C) 2012 Victor Carbune (victor@rosedu.org)
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef RenderVTTCue_h 26 #ifndef RenderVTTCue_h
27 #define RenderVTTCue_h 27 #define RenderVTTCue_h
28 28
29 #include "core/rendering/RenderBlockFlow.h" 29 #include "core/rendering/RenderBlockFlow.h"
30 #include "core/rendering/RenderInline.h"
31 #include "platform/geometry/FloatPoint.h"
32 #include "platform/heap/Handle.h" 30 #include "platform/heap/Handle.h"
33 31
34 namespace blink { 32 namespace blink {
35 33
36 class VTTCue; 34 class VTTCue;
37 class VTTCueBox; 35 class VTTCueBox;
38 36
39 class RenderVTTCue final : public RenderBlockFlow { 37 class RenderVTTCue final : public RenderBlockFlow {
40 public: 38 public:
41 explicit RenderVTTCue(VTTCueBox*); 39 explicit RenderVTTCue(VTTCueBox*);
42 40
43 virtual void trace(Visitor*) override; 41 virtual void trace(Visitor*) override;
44 private: 42 private:
45 virtual void layout() override; 43 virtual void layout() override;
46 44
47 bool isOutside() const; 45 bool isOutside() const;
48 bool isOverlapping() const; 46 bool isOverlapping() const;
49 bool shouldSwitchDirection(InlineFlowBox*, LayoutUnit) const; 47 bool shouldSwitchDirection(InlineFlowBox*, LayoutUnit) const;
50 48
51 void moveBoxesByStep(LayoutUnit); 49 void moveBoxesByStep(LayoutUnit);
52 bool switchDirection(bool&, LayoutUnit&); 50 bool switchDirection(bool&, LayoutUnit&);
53 51
54 bool findFirstLineBox(InlineFlowBox*&); 52 bool findFirstLineBox(InlineFlowBox*&);
55 bool initializeLayoutParameters(InlineFlowBox*, LayoutUnit&, LayoutUnit&); 53 bool initializeLayoutParameters(InlineFlowBox*, LayoutUnit&, LayoutUnit&);
56 void placeBoxInDefaultPosition(LayoutUnit, bool&); 54 void placeBoxInDefaultPosition(LayoutUnit, bool&);
57 void repositionCueSnapToLinesSet(); 55 void repositionCueSnapToLinesSet();
58 void repositionCueSnapToLinesNotSet(); 56 void repositionCueSnapToLinesNotSet();
59 57
60 RawPtrWillBeMember<VTTCue> m_cue; 58 RawPtrWillBeMember<VTTCue> m_cue;
61 FloatPoint m_fallbackPosition; 59 LayoutPoint m_defaultPosition;
62 }; 60 };
63 61
64 } // namespace blink 62 } // namespace blink
65 63
66 #endif // RenderVTTCue_h 64 #endif // RenderVTTCue_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderVTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698