Chromium Code Reviews| Index: Source/core/html/HTMLProgressElement.cpp |
| diff --git a/Source/core/html/HTMLProgressElement.cpp b/Source/core/html/HTMLProgressElement.cpp |
| index ed23025a01191217a732299473644f75c56b6545..a2006c19c8fbe828d71c592e29c2eccb96ec2e82 100644 |
| --- a/Source/core/html/HTMLProgressElement.cpp |
| +++ b/Source/core/html/HTMLProgressElement.cpp |
| @@ -104,7 +104,7 @@ void HTMLProgressElement::setValue(double value, ExceptionState& exceptionState) |
| exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::failedToSet("value", "HTMLProgressElement", ExceptionMessages::notAFiniteNumber(value))); |
| return; |
| } |
| - setAttribute(valueAttr, String::number(value >= 0 ? value : 0)); |
| + setAttribute(valueAttr, AtomicString::number(value >= 0 ? value : 0)); |
|
eseidel
2013/11/24 21:37:44
std::max(0, value)?
|
| } |
| double HTMLProgressElement::max() const |
| @@ -119,7 +119,7 @@ void HTMLProgressElement::setMax(double max, ExceptionState& exceptionState) |
| exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::failedToSet("max", "HTMLProgressElement", ExceptionMessages::notAFiniteNumber(max))); |
| return; |
| } |
| - setAttribute(maxAttr, String::number(max > 0 ? max : 1)); |
| + setAttribute(maxAttr, AtomicString::number(max > 0 ? max : 1)); |
|
eseidel
2013/11/24 21:37:44
std::max(1, value)?
Inactive
2013/11/24 22:06:20
This is not equivalent. 0.5 is a valid input value
|
| } |
| double HTMLProgressElement::position() const |