Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 84713002: Add number() static methods to AtomicString class (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLBodyElement.cpp
diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp
index e31e3414741b93e407ecac5f5c16db1b6a58f842..0fd9ca3ba327989537159b4d444043db2a4dc9c4 100644
--- a/Source/core/html/HTMLBodyElement.cpp
+++ b/Source/core/html/HTMLBodyElement.cpp
@@ -166,10 +166,10 @@ Node::InsertionNotificationRequest HTMLBodyElement::insertedInto(ContainerNode*
HTMLFrameElementBase* ownerFrameElement = toHTMLFrameElementBase(ownerElement);
int marginWidth = ownerFrameElement->marginWidth();
if (marginWidth != -1)
- setAttribute(marginwidthAttr, String::number(marginWidth));
+ setAttribute(marginwidthAttr, AtomicString::number(marginWidth));
int marginHeight = ownerFrameElement->marginHeight();
if (marginHeight != -1)
- setAttribute(marginheightAttr, String::number(marginHeight));
+ setAttribute(marginheightAttr, AtomicString::number(marginHeight));
eseidel 2013/11/24 21:37:44 Looks like some of these could use the helpers on
Inactive 2013/11/24 22:30:01 Excellent point, I'll update everywhere to use the
Inactive 2013/11/24 23:19:17 Done.
}
}
return InsertionDone;

Powered by Google App Engine
This is Rietveld 408576698