Add number() static methods to AtomicString class

Source/core/html/HTMLProgressElement.cpp

 /*
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 86 matching lines @@
     double value = parseToDoubleForNumberType(fastGetAttribute(valueAttr));
     return !std::isfinite(value) || value < 0 ? 0 : std::min(value, max());
 }
 
 void HTMLProgressElement::setValue(double value, ExceptionState& exceptionState)
 {
     if (!std::isfinite(value)) {
         exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::failedToSet("value", "HTMLProgressElement", ExceptionMessages::notAFiniteNumber(value)));
         return;
     }
-    setAttribute(valueAttr, String::number(value >= 0 ? value : 0));
+    setAttribute(valueAttr, AtomicString::number(value >= 0 ? value : 0));

[eseidel, 2013/11/24 21:37:44]

std::max(0, value)?

 }
 
 double HTMLProgressElement::max() const
 {
     double max = parseToDoubleForNumberType(getAttribute(maxAttr));
     return !std::isfinite(max) || max <= 0 ? 1 : max;
 }
 
 void HTMLProgressElement::setMax(double max, ExceptionState& exceptionState)
 {
     if (!std::isfinite(max)) {
         exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::failedToSet("max", "HTMLProgressElement", ExceptionMessages::notAFiniteNumber(max)));
         return;
     }
-    setAttribute(maxAttr, String::number(max > 0 ? max : 1));
+    setAttribute(maxAttr, AtomicString::number(max > 0 ? max : 1));

[eseidel, 2013/11/24 21:37:44]

std::max(1, value)?

[Inactive, 2013/11/24 22:06:20]

This is not equivalent. 0.5 is a valid input value but would be converted to 1
std::max(1, value).

By the way, this code is not according to specification. The specification says
that if the input value is inferior or equal to 0, it should be ignored.
Currently, we reset the max to 1.0 in this case:
http://www.whatwg.org/specs/web-apps/current-work/#dom-progress-max
http://www.whatwg.org/specs/web-apps/current-work/#limited-to-numbers-greater...

 }
 
 double HTMLProgressElement::position() const
 {
     if (!isDeterminate())
         return HTMLProgressElement::IndeterminatePosition;
     return value() / max();
 }
 
 bool HTMLProgressElement::isDeterminate() const
@@ skipping 30 matching lines @@
 
     inner->appendChild(bar);
 }
 
 bool HTMLProgressElement::shouldAppearIndeterminate() const
 {
     return !isDeterminate();
 }
 
 } // namespace