Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 845963005: trooper-o-matic: Add patch attempt timeline view to CQ graphs (Closed)

Created:
5 years, 11 months ago by alancutter (OOO until 2018)
Modified:
5 years, 11 months ago
Reviewers:
Sergey Berezin, ojan
CC:
chromium-reviews, seanmccullough
Base URL:
https://chromium.googlesource.com/infra/infra.git@+addAlternateBuildViews
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

trooper-o-matic: Add patch attempt timeline view to CQ graphs This change adds an additional view mode to the CQ graph patch summary lists to view the patch attempts on a timeline with indications of success or failure with failure reasons. This feature should make it easier to identify clusters of failures in time across multiple patch attempts e.g. all try jobs failing to trigger for 20 minutes. Committed: https://chromium.googlesource.com/infra/infra/+/acac01deba9c382c53406eb8ff4ca890bad80846

Patch Set 1 #

Patch Set 2 : Attempts Timeline #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -33 lines) Patch
M appengine/trooper_o_matic/model/cqstats-graph-data.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/trooper_o_matic/model/cqstats-ratio-graph-data.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/trooper_o_matic/model/patch-summary.html View 1 2 3 4 3 chunks +44 lines, -2 lines 0 comments Download
M appengine/trooper_o_matic/model/patch-summary-list.html View 1 2 chunks +41 lines, -3 lines 0 comments Download
M appengine/trooper_o_matic/ui/tom-cq-graph.html View 1 1 chunk +4 lines, -5 lines 0 comments Download
M appengine/trooper_o_matic/ui/tom-cq-graphs.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M appengine/trooper_o_matic/ui/tom-patch-summary.css View 1 2 3 1 chunk +30 lines, -1 line 0 comments Download
M appengine/trooper_o_matic/ui/tom-patch-summary.html View 1 2 3 4 3 chunks +29 lines, -10 lines 0 comments Download
M appengine/trooper_o_matic/ui/tom-patch-summary-list.css View 1 chunk +1 line, -1 line 0 comments Download
M appengine/trooper_o_matic/ui/tom-patch-summary-list.html View 1 3 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alancutter (OOO until 2018)
Demo: http://attempt-timeline.trooper-o-matic.appspot.com/cq/chromium Screenshot: http://i.imgur.com/FMZsXVt.png
5 years, 11 months ago (2015-01-13 09:34:41 UTC) #2
Sergey Berezin
LGTM, thanks Alan! I didn't really go into much detail, since I'm not that familiar ...
5 years, 11 months ago (2015-01-14 01:28:46 UTC) #3
ojan
lgtm +seanmccullough, who should probably start taking over the polymer side of these reviews. https://codereview.chromium.org/845963005/diff/60001/appengine/trooper_o_matic/ui/tom-patch-summary.html ...
5 years, 11 months ago (2015-01-15 02:48:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845963005/80001
5 years, 11 months ago (2015-01-19 22:05:04 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/infra/infra/+/acac01deba9c382c53406eb8ff4ca890bad80846
5 years, 11 months ago (2015-01-19 22:07:37 UTC) #7
alancutter (OOO until 2018)
5 years, 11 months ago (2015-01-19 23:19:01 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/845963005/diff/60001/appengine/trooper_o_mati...
File appengine/trooper_o_matic/ui/tom-patch-summary.html (right):

https://codereview.chromium.org/845963005/diff/60001/appengine/trooper_o_mati...
appengine/trooper_o_matic/ui/tom-patch-summary.html:60: title="{{ attempt |
attemptText }}">
On 2015/01/15 02:48:33, ojan wrote:
> This won't bind correctly if you change a member of attempt (e.g.
> attempt.success or attempt.durations.total), but don't actually replace the
> whole attempt object since the binding is based off object identity.

Done.

Powered by Google App Engine
This is Rietveld 408576698