Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: appengine/trooper_o_matic/ui/tom-cq-graph.html

Issue 845963005: trooper-o-matic: Add patch attempt timeline view to CQ graphs (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@+addAlternateBuildViews
Patch Set: Review changes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/trooper_o_matic/ui/tom-cq-graph.html
diff --git a/appengine/trooper_o_matic/ui/tom-cq-graph.html b/appengine/trooper_o_matic/ui/tom-cq-graph.html
index ac7606bdbd148c018881a49968c08ead6372b202..7111a5f7ce89c0f81d9e0ced54e1cbfa34403f45 100644
--- a/appengine/trooper_o_matic/ui/tom-cq-graph.html
+++ b/appengine/trooper_o_matic/ui/tom-cq-graph.html
@@ -81,22 +81,21 @@ found in the LICENSE file.
if (!this._dygraph || !this.graph.data.rowItemsAvailable) {
return;
}
- this._patchSummaryList.list = [];
+ this._patchSummaryList.clear();
var row = this._dygraph.getSelection();
if (row !== -1) {
this._loading = true;
var self = this;
this.graph.data.rowItems(row).then(function(rowItems) {
self._loading = false;
- self._patchSummaryList.list = rowItems.items.map(function(item) {
+ self._patchSummaryList.set(rowItems.begin, rowItems.end,
+ rowItems.items.map(function(item) {
var itemValue = item[0];
var itemRef = item[1];
return new PatchSummary(itemValue, self.graph.itemUnit,
itemRef.issue, itemRef.patchset,
self.graph.itemAlertThreshold);
- });
- self._patchSummaryList.begin = rowItems.begin;
- self._patchSummaryList.end = rowItems.end;
+ }));
}).catch(log);
}
},
« no previous file with comments | « appengine/trooper_o_matic/model/patch-summary-list.html ('k') | appengine/trooper_o_matic/ui/tom-cq-graphs.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698