Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: appengine/trooper_o_matic/ui/tom-patch-summary-list.html

Issue 845963005: trooper-o-matic: Add patch attempt timeline view to CQ graphs (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@+addAlternateBuildViews
Patch Set: Review changes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/trooper_o_matic/ui/tom-patch-summary-list.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/trooper_o_matic/ui/tom-patch-summary-list.html
diff --git a/appengine/trooper_o_matic/ui/tom-patch-summary-list.html b/appengine/trooper_o_matic/ui/tom-patch-summary-list.html
index 09bd591a4e71e0512167323097fbdf7eaaf028cf..48a802a38e0ba5ad5c4b7cbb2868a56d1c033ca6 100644
--- a/appengine/trooper_o_matic/ui/tom-patch-summary-list.html
+++ b/appengine/trooper_o_matic/ui/tom-patch-summary-list.html
@@ -18,8 +18,8 @@ found in the LICENSE file.
<div class="list-box">
<div class="list-header">
<span class="header-title">Worst {{ model.unit }}</span><br>
- From: {{ model.begin }}<br>
- Until: {{ model.end }}
+ From: {{ model.graphInterval.begin | timestampToDateString }}<br>
+ Until: {{ model.graphInterval.end | timestampToDateString }}
<paper-button class="close" on-tap="{{ close }}">X</paper-button>
</div>
@@ -32,19 +32,32 @@ found in the LICENSE file.
<div class="metric-cell column header">Graph metric</div>
<div class="patch-cell column header">Patch</div>
<div class="column-container">
+
+ <template if="{{ $.viewMenu.value == 'jobs' }}">
+ <div class="column grow header">{{ $.viewMenu.subMenu.text }} jobs</div>
+ </template>
+
+ <template if="{{ $.viewMenu.value == 'timeline' }}">
+ <template bind="{{ model[$.viewMenu.subMenu.value] as interval }}">
+ <div class="column grow header">
+ Timeline Interval<br>
+ {{ interval.begin | timestampToLocaleString }}<br>
+ {{ interval.end | timestampToLocaleString }}
+ </div>
+ </template>
+ </template>
+
<template if="{{ $.viewMenu.value == 'summary' }}">
<template repeat="{{ column in _summaryColumns }}">
<div class="column header">{{ column.header }}</div>
</template>
</template>
- <template if="{{ $.viewMenu.value == 'jobs' }}">
- <div class="column grow header">{{ $.viewMenu.subMenu.text }} jobs</div>
- </template>
+
</div>
</div>
<div class="item-rows">
- <template repeat="{{ patchSummary in model.list }}">
+ <template repeat="{{ patchSummary in model._list }}">
<tom-patch-summary model="{{ patchSummary }}" viewMenu="{{ $.viewMenu }}"></tom-patch-summary>
</template>
</div>
@@ -58,7 +71,13 @@ found in the LICENSE file.
this._summaryColumns = PatchSummary.summaryColumns;
},
close: function() {
- this.model.list = [];
+ this.model.clear();
+ },
+ timestampToDateString: function(timestamp) {
+ return new Date(timestamp * 1000).toString();
+ },
+ timestampToLocaleString: function(timestamp) {
+ return new Date(timestamp * 1000).toLocaleString();
},
});
</script>
« no previous file with comments | « appengine/trooper_o_matic/ui/tom-patch-summary-list.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698