Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 860003002: [x86] Use AVX in Crankshaft when available. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Use AVX in Crankshaft when available. R=verwaest@chromium.org Committed: https://crrev.com/622be8f71e70b6ece4ea6a89bcfa1bc4be5e70c1 Cr-Commit-Position: refs/heads/master@{#26159} Committed: https://crrev.com/03fbb053b39b4765a5b848e4b3dddbccb8d19889 Cr-Commit-Position: refs/heads/master@{#26235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +31 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +31 lines, -9 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-20 13:51:38 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-20 13:52:14 UTC) #2
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-20 13:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860003002/1
5 years, 11 months ago (2015-01-20 13:54:48 UTC) #6
Benedikt Meurer
Committed patchset #1 (id:1) manually as 622be8f71e70b6ece4ea6a89bcfa1bc4be5e70c1 (presubmit successful).
5 years, 11 months ago (2015-01-20 13:59:31 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/622be8f71e70b6ece4ea6a89bcfa1bc4be5e70c1 Cr-Commit-Position: refs/heads/master@{#26159}
5 years, 11 months ago (2015-01-20 13:59:34 UTC) #9
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/863423002/ by machenbach@chromium.org. ...
5 years, 11 months ago (2015-01-22 21:26:49 UTC) #10
Benedikt Meurer
Committed patchset #1 (id:1) manually as 03fbb053b39b4765a5b848e4b3dddbccb8d19889 (presubmit successful).
5 years, 11 months ago (2015-01-23 08:25:32 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03fbb053b39b4765a5b848e4b3dddbccb8d19889 Cr-Commit-Position: refs/heads/master@{#26235}
5 years, 11 months ago (2015-01-23 08:25:36 UTC) #12
Johann
5 years, 11 months ago (2015-01-23 19:10:25 UTC) #13
Message was sent while issue was closed.
FYI - the cpu detection in v8/src/base/cpu.cc doesn't appear to take into
account the OSXSAVE bit:

https://gerrit.chromium.org/gerrit/#/c/73502/
and
https://software.intel.com/en-us/articles/how-to-detect-new-instruction-suppo...

of course, even with those checks in place libvpx is failing in a potentially
similar way. if you know of access to a winxp machine i could use to verify
this, i would appreciate it.

Powered by Google App Engine
This is Rietveld 408576698