content/browser/service_worker/service_worker_register_job.h - Issue 845313004: Service Worker: Improve error messages from register().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 845313004: Service Worker: Improve error messages from register(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git-cl format Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_job_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index f5eb71113c38e09eca151ed497dc7bef23fe0626..16e3cd655ea0067c8b4a2ecdd6beaa8e64fffbe0 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -38,6 +38,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

public ServiceWorkerRegistration::Listener {

public:

typedef base::Callback<void(ServiceWorkerStatusCode status,

+ const std::string& status_message,

ServiceWorkerRegistration* registration)>

RegistrationCallback;

@@ -131,8 +132,12 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

void ActivateAndContinue();

void OnActivateFinished(ServiceWorkerStatusCode status);

void Complete(ServiceWorkerStatusCode status);

- void CompleteInternal(ServiceWorkerStatusCode status);

+ void Complete(ServiceWorkerStatusCode status,

+ const std::string& status_message);

+ void CompleteInternal(ServiceWorkerStatusCode status,

+ const std::string& status_message);

void ResolvePromise(ServiceWorkerStatusCode status,

+ const std::string& status_message,

ServiceWorkerRegistration* registration);

// EmbeddedWorkerInstance::Listener override of OnPausedAfterDownload.

@@ -162,6 +167,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase,

bool doom_installing_worker_;

bool is_promise_resolved_;

ServiceWorkerStatusCode promise_resolved_status_;

+ std::string promise_resolved_status_message_;

scoped_refptr<ServiceWorkerRegistration> promise_resolved_registration_;

base::WeakPtrFactory<ServiceWorkerRegisterJob> weak_factory_;