Autofill - don't show server cards in android preferences

Autofill - don't show server cards in android preferences

These aren't editable locally. There will eventually be a UI for "forgetting" the unmasked ones and a button to take you to the wallet web interface or app to make edits.

BUG=none

Committed: https://crrev.com/c3f226b60b74a210614784c8c00b0d58584eefbb
Cr-Commit-Position: refs/heads/master@{#311303}

[Evan Stade, 2015-01-13 00:57:19]

estade@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-01-13 01:05:14]

https://codereview.chromium.org/845173003/diff/1/chrome/browser/autofill/andr...
File chrome/browser/autofill/android/personal_data_manager_android.cc (right):

https://codereview.chromium.org/845173003/diff/1/chrome/browser/autofill/andr...
chrome/browser/autofill/android/personal_data_manager_android.cc:233: return
personal_data_manager_->GetLocalCreditCards().size();
Is there a bug number? Why do we only want to return local cards only? Can you
update the CL description to explain that?

https://codereview.chromium.org/845173003/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

https://codereview.chromium.org/845173003/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/autofill_options_handler.cc:463: const
std::vector<CreditCard*>& cards = personal_data_->GetLocalCreditCards();
Android does not use webui. CL description says this is Android only change?

[Evan Stade, 2015-01-13 01:12:52]

https://codereview.chromium.org/845173003/diff/1/chrome/browser/autofill/andr...
File chrome/browser/autofill/android/personal_data_manager_android.cc (right):

https://codereview.chromium.org/845173003/diff/1/chrome/browser/autofill/andr...
chrome/browser/autofill/android/personal_data_manager_android.cc:233: return
personal_data_manager_->GetLocalCreditCards().size();
On 2015/01/13 01:05:14, aurimas wrote:
> Is there a bug number? Why do we only want to return local cards only? Can you
> update the CL description to explain that?

description updated

https://codereview.chromium.org/845173003/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

https://codereview.chromium.org/845173003/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/autofill_options_handler.cc:463: const
std::vector<CreditCard*>& cards = personal_data_->GetLocalCreditCards();
On 2015/01/13 01:05:14, aurimas wrote:
> Android does not use webui. CL description says this is Android only change?

adding the GetLocalCreditCards function allows this code to get simpler. There's
no behavioral change here.

[aurimas (slooooooooow), 2015-01-13 01:17:12]

lgtm

[Evan Stade, 2015-01-13 01:43:41]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:44:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845173003/1

[commit-bot: I haz the power, 2015-01-13 01:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 01:57:41]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-01-13 17:52:06]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-01-13 17:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/845173003/20001

[commit-bot: I haz the power, 2015-01-13 19:08:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-13 19:09:00]

Patchset 2 (id:??) landed as
https://crrev.com/c3f226b60b74a210614784c8c00b0d58584eefbb
Cr-Commit-Position: refs/heads/master@{#311303}