Autofill - don't show server cards in android preferences

chrome/browser/ui/webui/options/autofill_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/autofill_options_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 442 matching lines @@
   for (size_t i = 0; i < profiles.size(); ++i) {
     base::ListValue* entry = new base::ListValue();
     entry->Append(new base::StringValue(profiles[i]->guid()));
     entry->Append(new base::StringValue(labels[i]));
     addresses.Append(entry);
   }
 
   web_ui()->CallJavascriptFunction("AutofillOptions.setAddressList", addresses);
 
   base::ListValue credit_cards;
-  const std::vector<CreditCard*>& cards = personal_data_->GetCreditCards();
-  for (std::vector<CreditCard*>::const_iterator iter = cards.begin();
-       iter != cards.end(); ++iter) {
-    const CreditCard* card = *iter;
-    if (card->record_type() != CreditCard::LOCAL_CARD)
-      continue;
-
+  const std::vector<CreditCard*>& cards = personal_data_->GetLocalCreditCards();

[aurimas (slooooooooow), 2015/01/13 01:05:14]

Android does not use webui. CL description says this is Android only change?

[Evan Stade, 2015/01/13 01:12:52]

adding the GetLocalCreditCards function allows this code to get simpler. There's
no behavioral change here.

+  for (const CreditCard* card : cards.begin()) {
     // TODO(estade): this should be a dictionary.
     base::ListValue* entry = new base::ListValue();
     entry->Append(new base::StringValue(card->guid()));
     entry->Append(new base::StringValue(card->Label()));
     entry->Append(new base::StringValue(
         webui::GetBitmapDataUrlFromResource(
             CreditCard::IconResourceId(card->type()))));
     entry->Append(new base::StringValue(card->TypeForDisplay()));
     credit_cards.Append(entry);
   }
@@ skipping 266 matching lines @@
   scoped_ptr<base::ListValue> components(new base::ListValue);
   GetAddressComponents(
       base::UTF16ToUTF8(profile.GetRawInfo(autofill::ADDRESS_HOME_COUNTRY)),
       profile.language_code(),
       components.get(),
       NULL);
   address->Set(kComponents, components.release());
 }
 
 }  // namespace options