chrome/browser/ui/webui/options/autofill_options_handler.cc - Issue 845173003: Autofill - don't show server cards in android preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/autofill_options_handler.cc

Issue 845173003: Autofill - don't show server cards in android preferences (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | components/autofill/core/browser/personal_data_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/autofill_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/autofill_options_handler.cc b/chrome/browser/ui/webui/options/autofill_options_handler.cc

index 9f7db4a3307f82f54fcf9c432b4f8f5e6f37c706..d567f8b6020fce83bc5ea393587aefd10b8fe3c4 100644

--- a/chrome/browser/ui/webui/options/autofill_options_handler.cc

+++ b/chrome/browser/ui/webui/options/autofill_options_handler.cc

@@ -460,13 +460,8 @@ void AutofillOptionsHandler::LoadAutofillData() {

web_ui()->CallJavascriptFunction("AutofillOptions.setAddressList", addresses);

base::ListValue credit_cards;

- const std::vector<CreditCard*>& cards = personal_data_->GetCreditCards();

- for (std::vector<CreditCard*>::const_iterator iter = cards.begin();

- iter != cards.end(); ++iter) {

- const CreditCard* card = *iter;

- if (card->record_type() != CreditCard::LOCAL_CARD)

- continue;

+ const std::vector<CreditCard*>& cards = personal_data_->GetLocalCreditCards();

+ for (const CreditCard* card : cards) {

// TODO(estade): this should be a dictionary.

base::ListValue* entry = new base::ListValue();

entry->Append(new base::StringValue(card->guid()));