Issue 844473003: Add CPP def for PNaCl biased bc newlib builds to omit memcpy, memmove, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 844473003: Add CPP def for PNaCl biased bc newlib builds to omit memcpy, memmove, etc. (Closed)

Created:
5 years, 11 months ago by jvoung (off chromium)

Modified:
5 years, 11 months ago

Reviewers:
Derek Schuff, JF

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Add CPP def for PNaCl biased bc newlib builds to omit memcpy, memmove, etc. Previously, only the le32 build omitted memcpy, memmove, and memset. However, the same miscompilation from specialization based on incomplete callers is possible with biased bitcode as well. Update Newlib deps for: https://codereview.chromium.org/855013002/ da71745 Make mem{cpy,move,set} pnacl bitcode disablement apply to biased bitcode. Fixes the callingconv and other nonpexe test failures in: BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026 R=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=0542dc33e80062c6e41551c573dcf7f89ce30880

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	pnacl/COMPONENT_REVISIONS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	toolchain_build/pnacl_targetlibs.py	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

jvoung (off chromium)

5 years, 11 months ago (2015-01-16 21:51:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
0542dc33e80062c6e41551c573dcf7f89ce30880 (presubmit successful).