Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: toolchain_build/pnacl_targetlibs.py

Issue 844473003: Add CPP def for PNaCl biased bc newlib builds to omit memcpy, memmove, etc. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: update newlib rev to test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/COMPONENT_REVISIONS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: toolchain_build/pnacl_targetlibs.py
diff --git a/toolchain_build/pnacl_targetlibs.py b/toolchain_build/pnacl_targetlibs.py
index 7cf1ad4f153a1a64f1b39b585ace827e3bb2f248..84571838784f7986d17a6b1a61b569490d7d7f11 100755
--- a/toolchain_build/pnacl_targetlibs.py
+++ b/toolchain_build/pnacl_targetlibs.py
@@ -326,6 +326,7 @@ def TargetLibs(bias_arch, is_canonical):
return GSDJoin(component_name, bias_arch)
target_triple = TripleFromArch(bias_arch)
newlib_triple = target_triple if not IsBCArch(bias_arch) else 'le32-nacl'
+ newlib_cpp_flags = ' -DPNACL_BITCODE' if IsBCArch(bias_arch) else ''
clang_libdir = os.path.join(
'%(output)s', 'lib', 'clang', CLANG_VER, 'lib', target_triple)
libc_libdir = os.path.join('%(output)s', MultilibLibDir(bias_arch))
@@ -337,7 +338,9 @@ def TargetLibs(bias_arch, is_canonical):
command.SkipForIncrementalCommand(
['sh', '%(newlib_src)s/configure'] +
TargetTools(bias_arch) +
- ['CFLAGS_FOR_TARGET=' + TargetLibCflags(bias_arch),
+ ['CFLAGS_FOR_TARGET=' +
+ TargetLibCflags(bias_arch) +
+ newlib_cpp_flags,
'--prefix=',
'--disable-newlib-supplied-syscalls',
'--disable-texinfo',
« no previous file with comments | « pnacl/COMPONENT_REVISIONS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698