Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 843913006: Reverting due to Android builders breakage. Subsequent fixes did not fix. (Closed)

Created:
5 years, 11 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 11 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, tim+watch_chromium.org, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-notifications_chromium.org, maxbogue+watch_chromium.org, jam, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, erikwright+watch_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reverting due to Android builders breakage. Subsequent fixes did not fix. Revert "Use SuppressFBWarnings to suppress findbugs warnings" This reverts commit 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138. Revert "Temporarily add a workaround for findbugs." This reverts commit 790b64ba7f5343b6b99c97e8deaa635e1e9422d0. Revert "Temporarily remove some findbugs "known bugs"" This reverts commit 5a1c59272e7fd23116bcec8b952474e62bdcf7d3. NOTRY=true TBR=cjhopman@chromium.org Committed: https://crrev.com/710d2f69b76e7b997307a7096e31029857e8c7fb Cr-Commit-Position: refs/heads/master@{#311630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -115 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/PerfTraceEvent.java View 2 chunks +0 lines, -3 lines 0 comments Download
D base/android/java/src/org/chromium/base/annotations/SuppressFBWarnings.java View 1 chunk +0 lines, -20 lines 0 comments Download
M base/android/java/templates/NativeLibraries.template View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/findbugs_filter/findbugs_exclude.xml View 2 chunks +86 lines, -1 line 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +25 lines, -0 lines 0 comments Download
M build/get_landmines.py View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 5 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java View 2 chunks +0 lines, -2 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 5 chunks +3 lines, -19 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 3 chunks +0 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeFieldsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeReturnValuesTest.java View 3 chunks +14 lines, -16 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeTestBase.java View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 2 chunks +0 lines, -2 lines 0 comments Download
A tools/android/findbugs_plugin/test/expected_result.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843913006/1
5 years, 11 months ago (2015-01-15 05:49:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 05:50:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/710d2f69b76e7b997307a7096e31029857e8c7fb Cr-Commit-Position: refs/heads/master@{#311630}
5 years, 11 months ago (2015-01-15 05:51:26 UTC) #5
Anand Mistry (off Chromium)
5 years, 11 months ago (2015-01-15 07:09:00 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/827123006/ by amistry@chromium.org.

The reason for reverting is: Didn't fix the Android builders..

Powered by Google App Engine
This is Rietveld 408576698