base/android/java/templates/NativeLibraries.template - Issue 843913006: Reverting due to Android builders breakage. Subsequent fixes did not fix.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/java/templates/NativeLibraries.template

Issue 843913006: Reverting due to Android builders breakage. Subsequent fixes did not fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/annotations/SuppressFBWarnings.java ('k') | build/android/findbugs_filter/findbugs_exclude.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.base.library_loader;	5 package org.chromium.base.library_loader;

6	6

7 import org.chromium.base.annotations.SuppressFBWarnings;

8

9 @SuppressFBWarnings

10 public class NativeLibraries {	7 public class NativeLibraries {

11 /**	8 /**

12 * IMPORTANT NOTE: The variables defined here must _not_ be 'final'.	9 * IMPORTANT NOTE: The variables defined here must _not_ be 'final'.

13 *	10 *

14 * The reason for this is very subtle:	11 * The reason for this is very subtle:

15 *	12 *

16 * - This template is used to generate several distinct, but similar	13 * - This template is used to generate several distinct, but similar

17 * files used in different contexts:	14 * files used in different contexts:

18 *	15 *

19 * o .../gen/templates/org/chromium/base/library_loader/NativeLibraries.ja va	16 * o .../gen/templates/org/chromium/base/library_loader/NativeLibraries.ja va

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
86 // This is the expected version of the 'main' native library, which is the o ne that	83 // This is the expected version of the 'main' native library, which is the o ne that

87 // implements the initial set of base JNI functions including	84 // implements the initial set of base JNI functions including

88 // base::android::nativeGetVersionName()	85 // base::android::nativeGetVersionName()

89 static String sVersionNumber =	86 static String sVersionNumber =

90 #if defined(NATIVE_LIBRARIES_VERSION_NUMBER)	87 #if defined(NATIVE_LIBRARIES_VERSION_NUMBER)

91 NATIVE_LIBRARIES_VERSION_NUMBER;	88 NATIVE_LIBRARIES_VERSION_NUMBER;

92 #else	89 #else

93 "";	90 "";

94 #endif	91 #endif

95 }	92 }

OLD	NEW