android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java - Issue 843913006: Reverting due to Android builders breakage. Subsequent fixes did not fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

Issue 843913006: Reverting due to Android builders breakage. Subsequent fixes did not fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentsClient.java ('k') | base/android/java/src/org/chromium/base/PerfTraceEvent.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

index c1c5249805de343f769903a53bc3175861c00dd8..3edf1d355e2c02bf3f70c4cba7b729c34262e04a 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

@@ -11,7 +11,6 @@ import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;

import org.chromium.android_webview.AwContents;

import org.chromium.base.ThreadUtils;

-import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

@@ -121,7 +120,6 @@ public class ArchiveTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

- @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")

public void testExplicitBadPath() throws Throwable {

final String path = new File("/foo/bar/baz.mht").getAbsolutePath();

deleteFile(path);

@@ -134,7 +132,6 @@ public class ArchiveTest extends AwTestBase {

@SmallTest

@Feature({"AndroidWebView"})

- @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")

public void testAutoBadPath() throws Throwable {

final String path = new File("/foo/bar/").getAbsolutePath();

deleteFile(path);