Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 8438028: ntp: remove ShownSectionHandler and all references to it (Closed)

Created:
9 years, 1 month ago by Evan Stade
Modified:
9 years, 1 month ago
Reviewers:
csilv, Dan Beam, Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, Erik does not do reviews, kkania, mihaip+watch_chromium.org, Aaron Boodman, anantha, robertshield, dyu1, Paweł Hajdan Jr., dennis_jeffrey, estade+watch_chromium.org
Visibility:
Public.

Description

ntp: remove ShownSectionHandler and all references to it it's not a part of ntp4. It controlled the display state of the various sections in ntp3. BUG=76706 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108399

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : more functional test updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -977 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 3 chunks +0 lines, -141 lines 0 comments Download
M chrome/browser/extensions/apps_promo.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/apps_promo.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/apps_promo_unittest.cc View 1 3 chunks +0 lines, -117 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/ui/webui/ntp/shown_sections_handler.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/webui/ntp/shown_sections_handler.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/ui/webui/ntp/shown_sections_handler_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/test/functional/ntp.py View 1 2 1 chunk +0 lines, -198 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
9 years, 1 month ago (2011-11-02 21:52:53 UTC) #1
Nirnimesh
Please also remove the relevant tests from chrome/test/functional/ntp.py -- there's lots of references to GetNTPThumbnails/SetNTPThumbnails ...
9 years, 1 month ago (2011-11-02 22:04:41 UTC) #2
Evan Stade
done (GetNTPThumbnails is ok; GetNTPThumbnailMode is gone)
9 years, 1 month ago (2011-11-02 22:35:13 UTC) #3
Dan Beam
If this compiles, doesn't mess with NTP4, and doesn't break the tests, LGTM (<3 deleting ...
9 years, 1 month ago (2011-11-02 23:36:24 UTC) #4
Evan Stade
well the try runs are green from patch set 2, although the functional tests don't ...
9 years, 1 month ago (2011-11-02 23:45:59 UTC) #5
Nirnimesh
pyauto_functional_tests does not run by default. You'd need to use -t pyauto_functional_tests flag to the ...
9 years, 1 month ago (2011-11-02 23:50:31 UTC) #6
Evan Stade
ok thanks
9 years, 1 month ago (2011-11-03 00:10:54 UTC) #7
csilv
9 years, 1 month ago (2011-11-03 00:16:22 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698