Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: chrome/browser/extensions/apps_promo.cc

Issue 8438028: ntp: remove ShownSectionHandler and all references to it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more functional test updates Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/apps_promo.h ('k') | chrome/browser/extensions/apps_promo_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/apps_promo.cc
diff --git a/chrome/browser/extensions/apps_promo.cc b/chrome/browser/extensions/apps_promo.cc
index adc4b444a6b9fe888af1c36e94dc791510304e0d..38483a33162ba4019a14563d1707d10703b87bc6 100644
--- a/chrome/browser/extensions/apps_promo.cc
+++ b/chrome/browser/extensions/apps_promo.cc
@@ -10,7 +10,6 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/webui/ntp/shown_sections_handler.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/chrome_notification_types.h"
@@ -275,27 +274,11 @@ void AppsPromo::ExpireDefaultApps() {
SetPromoCounter(kDefaultAppsCounterMax + 1);
}
-void AppsPromo::MaximizeAppsIfNecessary() {
- PromoData promo = GetPromo();
-
- // Maximize the apps section of the NTP if this is the first time viewing the
- // specific promo and the current user group is targetted.
- if (GetLastPromoId() != promo.id) {
- if ((promo.user_group & GetCurrentUserGroup()) != 0)
- ShownSectionsHandler::SetShownSection(prefs_, APPS);
- SetLastPromoId(promo.id);
- }
-}
-
void AppsPromo::HidePromo() {
UMA_HISTOGRAM_ENUMERATION(extension_misc::kAppsPromoHistogram,
extension_misc::PROMO_CLOSE,
extension_misc::PROMO_BUCKET_BOUNDARY);
- // Put the apps section into menu mode, and maximize the recent section.
- ShownSectionsHandler::SetShownSection(prefs_, MENU_APPS);
- ShownSectionsHandler::SetShownSection(prefs_, THUMB);
-
ExpireDefaultApps();
}
« no previous file with comments | « chrome/browser/extensions/apps_promo.h ('k') | chrome/browser/extensions/apps_promo_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698