Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc

Issue 8438028: ntp: remove ShownSectionHandler and all references to it (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more functional test updates Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc b/chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc
index ab22e6586c4a706a18d832aa69ee0b85328f9a3b..79c4f49ffae5b143ec6e04a27a31197014048fc9 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui_uitest.cc
@@ -182,32 +182,3 @@ TEST_F(NewTabUITest, FLAKY_ChromeInternalLoadsNTP) {
&thumbnails_count));
EXPECT_GT(thumbnails_count, 0);
}
-
-// Bug 87200: Disable UpdateUserPrefsVersion for Windows
-#if defined(OS_WIN)
-#define MAYBE_UpdateUserPrefsVersion DISABLED_UpdateUserPrefsVersion
-#else
-#define MAYBE_UpdateUserPrefsVersion UpdateUserPrefsVersion
-#endif
-TEST_F(NewTabUITest, MAYBE_UpdateUserPrefsVersion) {
- // PrefService with JSON user-pref file only, no enforced or advised prefs.
- scoped_ptr<PrefService> prefs(new TestingPrefService);
-
- // Does the migration
- NewTabUI::RegisterUserPrefs(prefs.get());
-
- ASSERT_EQ(NewTabUI::current_pref_version(),
- prefs->GetInteger(prefs::kNTPPrefVersion));
-
- // Reset the version
- prefs->ClearPref(prefs::kNTPPrefVersion);
- ASSERT_EQ(0, prefs->GetInteger(prefs::kNTPPrefVersion));
-
- bool migrated = NewTabUI::UpdateUserPrefsVersion(prefs.get());
- ASSERT_TRUE(migrated);
- ASSERT_EQ(NewTabUI::current_pref_version(),
- prefs->GetInteger(prefs::kNTPPrefVersion));
-
- migrated = NewTabUI::UpdateUserPrefsVersion(prefs.get());
- ASSERT_FALSE(migrated);
-}
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698