Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 842223004: merge to XFA: Fix -Wnon-virtual-dtor compiler warnings. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, brucedawson
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

merge to XFA: Fix -Wnon-virtual-dtor compiler warnings. Original at URL: https://codereview.chromium.org/810883005 Note that the new code in XFA introduces many more of these, to be handled separately. TBR=brucedawson@chromium.org TBR=thestig@chromium.org BUG=https://code.google.com/p/pdfium/issues/detail?id=102 Committed: https://pdfium.googlesource.com/pdfium/+/e5b59cacbb7ed6bcefe25d736a315753dd764594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -52 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 6 chunks +7 lines, -10 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 4 chunks +5 lines, -2 lines 0 comments Download
M core/include/fxcodec/fx_codec_provider.h View 2 chunks +3 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_arb.h View 1 chunk +3 lines, -0 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 3 chunks +2 lines, -2 lines 0 comments Download
M core/include/fxge/fpf.h View 2 chunks +5 lines, -0 lines 0 comments Download
M core/include/fxge/fx_dib.h View 1 chunk +1 line, -2 lines 0 comments Download
M core/include/fxge/fx_font.h View 5 chunks +8 lines, -0 lines 0 comments Download
M core/include/fxge/fx_ge.h View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.h View 1 chunk +5 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/tagged_int.h View 3 chunks +6 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Module.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcrt/fx_arabic.h View 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 chunk +12 lines, -10 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 9 chunks +17 lines, -9 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 3 chunks +6 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 2 chunks +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 3 chunks +4 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as e5b59cacbb7ed6bcefe25d736a315753dd764594 (presubmit successful).
5 years, 11 months ago (2015-01-09 19:46:21 UTC) #1
Tom Sepez
5 years, 11 months ago (2015-01-09 19:47:14 UTC) #2
brucedawson
5 years, 11 months ago (2015-01-09 20:49:33 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698