core/include/fxcrt/fx_arb.h - Issue 842223004: merge to XFA: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcrt/fx_arb.h

Issue 842223004: merge to XFA: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxcrt/fx_arb.h

diff --git a/core/include/fxcrt/fx_arb.h b/core/include/fxcrt/fx_arb.h

index ed0370ff742ef01c780e620baae3f9abfd777b25..a1dc231a8d05076ea864229930d34b1094cefb6c 100644

--- a/core/include/fxcrt/fx_arb.h

+++ b/core/include/fxcrt/fx_arb.h

@@ -64,5 +64,8 @@ public:

virtual FX_BOOL EndChar() = 0;

virtual FX_INT32 GetBidiInfo(FX_INT32 &iStart, FX_INT32 &iCount) = 0;

virtual void Reset() = 0;

+protected:

+ ~IFX_BidiChar() { }

};

#endif

« no previous file with comments | « core/include/fxcodec/fx_codec_provider.h ('k') | core/include/fxcrt/fx_basic.h » ('j') | no next file with comments »