fpdfsdk/include/pdfwindow/PWL_Edit.h - Issue 842223004: merge to XFA: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/pdfwindow/PWL_Edit.h

Issue 842223004: merge to XFA: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/pdfwindow/PWL_Edit.h

diff --git a/fpdfsdk/include/pdfwindow/PWL_Edit.h b/fpdfsdk/include/pdfwindow/PWL_Edit.h

index 6af324d5f78ff57c9d04f25e843f264043e5140a..f7d7b6f8f11a5b3a9b8ce1650ddd2bf8c9f0f5fc 100644

--- a/fpdfsdk/include/pdfwindow/PWL_Edit.h

+++ b/fpdfsdk/include/pdfwindow/PWL_Edit.h

@@ -14,6 +14,7 @@ class IPWL_SpellCheck;

class IPWL_Filler_Notify

{

public:

+ virtual ~IPWL_Filler_Notify() { }

virtual void QueryWherePopup(void* pPrivateData, FX_FLOAT fPopupMin,FX_FLOAT fPopupMax,

FX_INT32 & nRet, FX_FLOAT & fPopupRet) = 0; //nRet: (0:bottom 1:top)

virtual void OnBeforeKeyStroke(FX_BOOL bEditOrList, void* pPrivateData, FX_INT32 nKeyCode,

« no previous file with comments | « fpdfsdk/include/javascript/IJavaScript.h ('k') | fpdfsdk/include/pdfwindow/PWL_EditCtrl.h » ('j') | no next file with comments »