Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 841663002: Oilpan: clarify why FrameOwner is a GC mixin. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: clarify why FrameOwner is a GC mixin. Add explanatory comment on why this interface derives from GarbageCollectedMixin with Oilpan enabled. R= BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/frame/FrameOwner.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-07 08:21:51 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-07 08:23:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841663002/1
5 years, 11 months ago (2015-01-07 08:24:26 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 08:24:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187957

Powered by Google App Engine
This is Rietveld 408576698