Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/core/frame/FrameOwner.h

Issue 841663002: Oilpan: clarify why FrameOwner is a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef FrameOwner_h 5 #ifndef FrameOwner_h
6 #define FrameOwner_h 6 #define FrameOwner_h
7 7
8 #include "core/dom/SandboxFlags.h" 8 #include "core/dom/SandboxFlags.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 // Oilpan: all FrameOwner instances are GCed objects. FrameOwner additionally
14 // derives from GarbageCollectedMixin so that Member<FrameOwner> references can
15 // be kept (e.g., Frame::m_owner.)
13 class FrameOwner : public WillBeGarbageCollectedMixin { 16 class FrameOwner : public WillBeGarbageCollectedMixin {
14 public: 17 public:
15 virtual ~FrameOwner() { } 18 virtual ~FrameOwner() { }
16 virtual void trace(Visitor*) { } 19 virtual void trace(Visitor*) { }
17 20
18 virtual bool isLocal() const = 0; 21 virtual bool isLocal() const = 0;
19 22
20 virtual SandboxFlags sandboxFlags() const = 0; 23 virtual SandboxFlags sandboxFlags() const = 0;
21 virtual void dispatchLoad() = 0; 24 virtual void dispatchLoad() = 0;
22 }; 25 };
23 26
24 } // namespace blink 27 } // namespace blink
25 28
26 #endif // FrameOwner_h 29 #endif // FrameOwner_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698