Source/core/frame/FrameOwner.h - Issue 841663002: Oilpan: clarify why FrameOwner is a GC mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameOwner.h

Issue 841663002: Oilpan: clarify why FrameOwner is a GC mixin. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/FrameOwner.h

diff --git a/Source/core/frame/FrameOwner.h b/Source/core/frame/FrameOwner.h

index f87a53dc25d0b7f6aa6a6936f85dcc94c848e7bf..64331472a7ab960ca27605a878564c3b14b9d763 100644

--- a/Source/core/frame/FrameOwner.h

+++ b/Source/core/frame/FrameOwner.h

@@ -10,6 +10,9 @@

namespace blink {

+// Oilpan: all FrameOwner instances are GCed objects. FrameOwner additionally

+// derives from GarbageCollectedMixin so that Member<FrameOwner> references can

+// be kept (e.g., Frame::m_owner.)

class FrameOwner : public WillBeGarbageCollectedMixin {

public:

virtual ~FrameOwner() { }

« no previous file with comments | « no previous file | no next file » | no next file with comments »