Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 841043002: Revert of Hack around broken snapshot generation in the GN build on Android. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
adamk, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Hack around broken snapshot generation in the GN build on Android. (patchset #1 id:1 of https://codereview.chromium.org/832413005/) Reason for revert: Suspected to block the current v8 roll: https://codereview.chromium.org/842783003/ Original issue's description: > Hack around broken snapshot generation in the GN build on Android. > > The generated snapshot just crashes on the device, but > disabling snapshots allows us to run V8 just fine which > is sufficient for our purposes at this point. > > Mojo/Sky are GN-only so we depend on the V8 GN build even if > it's not considered production for Chromium yet. > > R=jochen@chromium.org > > Committed: https://crrev.com/3e97df1ee8b8bfdddd63ad3c7b79960d24c83b74 > Cr-Commit-Position: refs/heads/master@{#25982} TBR=jochen@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7deccd18edadfbe9c15bf9d8615a9e7a25512f9f Cr-Commit-Position: refs/heads/master@{#25991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
Created Revert of Hack around broken snapshot generation in the GN build on Android.
5 years, 11 months ago (2015-01-08 10:43:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841043002/1
5 years, 11 months ago (2015-01-08 10:45:00 UTC) #2
commit-bot: I haz the power
Failed to apply patch for BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-08 10:45:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841043002/1
5 years, 11 months ago (2015-01-08 10:50:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 10:50:09 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 10:50:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7deccd18edadfbe9c15bf9d8615a9e7a25512f9f
Cr-Commit-Position: refs/heads/master@{#25991}

Powered by Google App Engine
This is Rietveld 408576698