BUILD.gn - Issue 841043002: Revert of Hack around broken snapshot generation in the GN build on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 841043002: Revert of Hack around broken snapshot generation in the GN build on Android. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 403914476116cbdb93fc6c2056b0304b03c772eb..6534eea85948104dffd43635282a3d14f370bc82 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -17,8 +17,7 @@

v8_interpreted_regexp = false

v8_object_print = false

v8_postmortem_support = false

-# TODO(eseidel): The snapshot generated by the GN Android build crashes.

-v8_use_snapshot = !is_android

+v8_use_snapshot = true

v8_enable_extra_checks = is_debug

v8_target_arch = cpu_arch

v8_random_seed = "314159265"

« no previous file with comments | « no previous file | no next file » | no next file with comments »