Add some more tests for column-span:all.

Add some more tests for column-span:all.

BUG=347325
R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188664

[Julien - ping for review, 2015-01-20 10:10:41]

lgtm but we need the description in the tests, not in the commit message.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/float.html (right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/float.html:3: <p>Below you should see a green
square, followed by the word 'PASS' (with large letter spacing).</p>
You put some nice description in the commit message above, why aren't they just
here in the test for everyone to enjoy them? This applies to all the tests.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/float.html:6: <div style="float:left; width:1em;
height:5em; background:green;"></div>
I don't know if that tests what you're saying:
* you're setting the height of the float explicitly so it's normal that it
stretches.
* more critical is that the float is the same color as as the column spanner so
you actually can't say visually if it stretches.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child-expected.html
(right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child-expected.html:9:
<div style="clear:lefT; border:1px solid black; padding:10px; width:100px;
height:100px; background:green;"></div>
Nit: left (no capital T)

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html
(right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html:7: <div
style="position:absolute; bottom:0; right:0; width:100%; height:100%;
background:green;"></div>
If you remove the paddings on the column spanner (which don't seem needed for
the test), you also remove the need for bottom / right.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/spanner-with-relpos-child.html (right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/spanner-with-relpos-child.html:4: <div
style="-webkit-columns:1em; -webkit-column-gap:1em; width:13em;">
Is this giving us much to use a width that is not a multiple of (column width +
column gap)? (this is triggering my test OCD)

[mstensho (USE GERRIT), 2015-01-20 10:31:48]

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/float.html (right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/float.html:3: <p>Below you should see a green
square, followed by the word 'PASS' (with large letter spacing).</p>
On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote:
> You put some nice description in the commit message above, why aren't they
just
> here in the test for everyone to enjoy them? This applies to all the tests.

Done.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/float.html:6: <div style="float:left; width:1em;
height:5em; background:green;"></div>
On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote:
> I don't know if that tests what you're saying:
> * you're setting the height of the float explicitly so it's normal that it
> stretches.
> * more critical is that the float is the same color as as the column spanner
so
> you actually can't say visually if it stretches.

I'm testing stretching of the spanner, not the float. But yeah, let's use
different colors.

Done.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child-expected.html
(right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child-expected.html:9:
<div style="clear:lefT; border:1px solid black; padding:10px; width:100px;
height:100px; background:green;"></div>
On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote:
> Nit: left (no capital T)

DonE.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html
(right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html:7: <div
style="position:absolute; bottom:0; right:0; width:100%; height:100%;
background:green;"></div>
On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote:
> If you remove the paddings on the column spanner (which don't seem needed for
> the test), you also remove the need for bottom / right.

I actually wanted to test that the abspos takes up the entire padding box, so I
want to keep this.

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
File LayoutTests/fast/multicol/span/spanner-with-relpos-child.html (right):

https://codereview.chromium.org/840953006/diff/1/LayoutTests/fast/multicol/sp...
LayoutTests/fast/multicol/span/spanner-with-relpos-child.html:4: <div
style="-webkit-columns:1em; -webkit-column-gap:1em; width:13em;">
On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote:
> Is this giving us much to use a width that is not a multiple of (column width
+
> column gap)? (this is triggering my test OCD)

You get 7 columns and 6 gaps. Everything should add up beautifully.

[mstensho (USE GERRIT), 2015-01-20 10:48:38]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-01-20 10:49:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840953006/20001

[commit-bot: I haz the power, 2015-01-20 12:35:56]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188664