LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html - Issue 840953006: Add some more tests for column-span:all.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html

Issue 840953006: Add some more tests for column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>Below you should see the word 'PASS' (with large letter spacing). Below the w ord there should be

	3 a green square with a black border.</p>

	4 <div style="-webkit-columns:1em; -webkit-column-gap:1em; width:13em;">

	5 P<br>A<br>S<br>S

	6 <div style="-webkit-column-span:all; position:relative; border:1px solid bla ck; padding:10px; width:100px; height:100px; background:red;">

	7 <div style="position:absolute; bottom:0; right:0; width:100%; height:100 %; background:green;"></div>
	Julien - ping for review 2015/01/20 10:10:41 If you remove the paddings on the column spanner ( If you remove the paddings on the column spanner (which don't seem needed for the test), you also remove the need for bottom / right. mstensho (USE GERRIT) 2015/01/20 10:31:48 I actually wanted to test that the abspos takes up Show quoted text On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote: > If you remove the paddings on the column spanner (which don't seem needed for > the test), you also remove the need for bottom / right. I actually wanted to test that the abspos takes up the entire padding box, so I want to keep this.
	8 </div>

	9 </div>

OLD	NEW