LayoutTests/fast/multicol/span/float.html - Issue 840953006: Add some more tests for column-span:all.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/float.html

Issue 840953006: Add some more tests for column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/span/float-expected.html » ('j') | LayoutTests/fast/multicol/span/relpos-spanner-with-abspos-child.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <p>Below you should see a green square, followed by the word 'PASS' (with large letter spacing).</p>
	Julien - ping for review 2015/01/20 10:10:41 You put some nice description in the commit messag You put some nice description in the commit message above, why aren't they just here in the test for everyone to enjoy them? This applies to all the tests. mstensho (USE GERRIT) 2015/01/20 10:31:48 Done. Show quoted text On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote: > You put some nice description in the commit message above, why aren't they just > here in the test for everyone to enjoy them? This applies to all the tests. Done.
	4 <div style="width:5em; -webkit-columns:1em; -webkit-column-gap:0;">

	5 <div style="-webkit-column-span:all; background:green;">

	6 <div style="float:left; width:1em; height:5em; background:green;"></div>
	Julien - ping for review 2015/01/20 10:10:41 I don't know if that tests what you're saying: * y I don't know if that tests what you're saying: * you're setting the height of the float explicitly so it's normal that it stretches. * more critical is that the float is the same color as as the column spanner so you actually can't say visually if it stretches. mstensho (USE GERRIT) 2015/01/20 10:31:48 I'm testing stretching of the spanner, not the flo Show quoted text On 2015/01/20 10:10:41, Julien Chaffraix - CET wrote: > I don't know if that tests what you're saying: > * you're setting the height of the float explicitly so it's normal that it > stretches. > * more critical is that the float is the same color as as the column spanner so > you actually can't say visually if it stretches. I'm testing stretching of the spanner, not the float. But yeah, let's use different colors. Done.
	7 </div>

	8 P<br>

	9 A<br>

	10 S<br>

	11 S<br>

	12 </div>

OLD	NEW