chrome/browser/ui/omnibox/omnibox_navigation_observer.h - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_navigation_observer.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_instant_controller_unittest.cc ('k') | chrome/browser/ui/omnibox/omnibox_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_navigation_observer.h

diff --git a/chrome/browser/ui/omnibox/omnibox_navigation_observer.h b/chrome/browser/ui/omnibox/omnibox_navigation_observer.h

index 39754d61b3605218e773cbc7b16b81185f10a69e..1d0a6bc3b7e2a87f9111f613e192b5103fdb07a9 100644

--- a/chrome/browser/ui/omnibox/omnibox_navigation_observer.h

+++ b/chrome/browser/ui/omnibox/omnibox_navigation_observer.h

@@ -79,7 +79,7 @@ class OmniboxNavigationObserver : public content::NotificationObserver,

const content::NotificationDetails& details) OVERRIDE;

// content::WebContentsObserver:

- virtual void NavigateToPendingEntry(

+ virtual void DidStartNavigationToPendingEntry(

const GURL& url,

content::NavigationController::ReloadType reload_type) OVERRIDE;

virtual void NavigationEntryCommitted(