chrome/browser/ui/omnibox/omnibox_navigation_observer.cc - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

index 736efa3f80f40c2bbff21954cc68ea45b2592241..b7b9057dff6ab6a61c118050e281a997a344b7ca 100644

--- a/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

+++ b/chrome/browser/ui/omnibox/omnibox_navigation_observer.cc

@@ -95,7 +95,7 @@ void OmniboxNavigationObserver::Observe(

controller->GetBrowserContext()->GetRequestContext());

}

WebContentsObserver::Observe(controller->GetWebContents());

- // NavigateToPendingEntry() will be called for this load as well.

+ // DidStartNavigationToPendingEntry() will be called for this load as well.

}

void OmniboxNavigationObserver::NavigationEntryCommitted(

@@ -113,7 +113,7 @@ void OmniboxNavigationObserver::WebContentsDestroyed(

delete this;

}

-void OmniboxNavigationObserver::NavigateToPendingEntry(

+void OmniboxNavigationObserver::DidStartNavigationToPendingEntry(

const GURL& url,

content::NavigationController::ReloadType reload_type) {

if (load_state_ == LOAD_NOT_SEEN) {

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_navigation_observer.h ('k') | chrome/browser/ui/sync/one_click_signin_helper.h » ('j') | no next file with comments »