Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: chrome/browser/ui/browser_instant_controller_unittest.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/omnibox/omnibox_navigation_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_instant_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_instant_controller_unittest.cc b/chrome/browser/ui/browser_instant_controller_unittest.cc
index 52540aa2f28eaefc4774cd7455e2c321ec42f8a6..1c8d9c04874c938438daa4eeb0e71670e62a854a 100644
--- a/chrome/browser/ui/browser_instant_controller_unittest.cc
+++ b/chrome/browser/ui/browser_instant_controller_unittest.cc
@@ -56,14 +56,14 @@ class FakeWebContentsObserver : public content::WebContentsObserver {
url_(contents->GetURL()),
num_reloads_(0) {}
- virtual void NavigateToPendingEntry(
+ virtual void DidStartNavigationToPendingEntry(
const GURL& url,
content::NavigationController::ReloadType reload_type) OVERRIDE {
// The tab reload event doesn't work with BrowserWithTestWindowTest.
- // So we capture the NavigateToPendingEntry, and use the
+ // So we capture the DidStartNavigationToPendingEntry, and use the
// BrowserWithTestWindowTest::NavigateAndCommit to simulate the complete
- // reload. Note that this will again trigger NavigateToPendingEntry, so we
- // remove this as observer.
+ // reload. Note that this will again trigger
+ // DidStartNavigationToPendingEntry, so we remove this as observer.
content::NavigationController* controller =
&web_contents()->GetController();
Observe(NULL);
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/omnibox/omnibox_navigation_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698